OCLOMRS-1122: Decode any HTML-encoding of the key#124
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts OCL subscription retrieval to tolerate HTML-entity encoded global property values (likely introduced by prior XSS-hardening), preventing invalid token/URL values from being used in the subscription workflow.
Changes:
- Unescapes HTML4 entities when reading the subscription URL and token from global properties.
- Adds a regression test validating HTML entity unescaping for both URL and token.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api/src/main/java/org/openmrs/module/openconceptlab/ImportServiceImpl.java | Unescapes HTML entities for subscription URL/token when building the Subscription. |
| api/src/test/java/org/openmrs/module/openconceptlab/ImportServiceTest.java | Adds test coverage ensuring HTML-escaped URL/token global properties are correctly unescaped. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ibacher
added a commit
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, it's been reported that some users are experiencing issues with the OCL subscription workflow that result in getting a 401 response even when everything looks correct. I suspect the issue relates to some of the XSS work we did last year, so this undoes that. I have not, however, done any rigorous attempt to prove that is the issue. In either case, this is pretty harmless.